Fix PointerOverOut test#46634
Closed
rozele wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63336621 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63336621 |
rozele
force-pushed
the
export-D63336621
branch
from
3a5446b to
dc95704
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63336621 |
rozele
force-pushed
the
export-D63336621
branch
from
dc95704 to
19c9729
Compare
Summary: Pull Request resolved: facebook#46634 The PointerEventPointerOverOut.js test case is broken due to a changed assumption about the name of the native tag property (`_nativeTag` vs. `__nativeTag`). This fixes the broken assumption. ## Changelog [General][Fixed] Fixed issue with W3C PointerEvents tests Reviewed By: NickGerleman Differential Revision: D63336621
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D63336621 |
rozele
force-pushed
the
export-D63336621
branch
from
19c9729 to
53d37f7
Compare
Contributor
|
This pull request has been merged in 68a6b69. |
Collaborator
|
This pull request was successfully merged by @rozele in 68a6b69 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The PointerEventPointerOverOut.js test case is broken due to a changed assumption about the name of the native tag property (
_nativeTagvs.__nativeTag). This fixes the broken assumption.Changelog
[General][Fixed] Fixed issue with W3C PointerEvents tests
Reviewed By: NickGerleman
Differential Revision: D63336621